Fix #1156 - Move AuthProviders SyntheticBean generation to Runtime #1163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Runtime Signed-off-by: Ricardo Zanini <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ovider/src/test/java/io/quarkiverse/openapi/generator/it/creds/SimpleServerMockResource.java
Dismissed
Show dismissed
Hide dismissed
...vider/src/main/java/io/quarkiverse/openapi/generator/it/creds/CustomCredentialsProvider.java
Outdated
Show resolved
Hide resolved
Contributor
|
Thx for fixing this!! Once it is merged on main, I will rebase #1126 to remove redundancies |
Signed-off-by: Ricardo Zanini <[email protected]>
gabriel-farache
approved these changes
Jun 4, 2025
gmunozfe
approved these changes
Jun 4, 2025
Contributor
gmunozfe
left a comment
gmunozfe
left a comment
There was a problem hiding this comment.
Looks good to me, great work @ricardozanini !
...r/src/test/java/io/quarkiverse/openapi/generator/it/creds/CustomCredentialsProviderTest.java
Outdated
Show resolved
Hide resolved
…/java/io/quarkiverse/openapi/generator/it/creds/CustomCredentialsProviderTest.java Co-authored-by: Gonzalo Muñoz <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 5, 2025
…1163) * Fix #1156 - Move AuthProviders SyntheticBean generation to Runtime Signed-off-by: Ricardo Zanini <[email protected]> * Add a meaningful log message to IT Signed-off-by: Ricardo Zanini <[email protected]> * Update client/integration-tests/override-credential-provider/src/test/java/io/quarkiverse/openapi/generator/it/creds/CustomCredentialsProviderTest.java Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]>
7 tasks
ricardozanini
added a commit
that referenced
this pull request
Jun 11, 2025
… Runtime (#1172) * Fix #1156 - Move AuthProviders SyntheticBean generation to Runtime (#1163) * Fix #1156 - Move AuthProviders SyntheticBean generation to Runtime Signed-off-by: Ricardo Zanini <[email protected]> * Add a meaningful log message to IT Signed-off-by: Ricardo Zanini <[email protected]> * Update client/integration-tests/override-credential-provider/src/test/java/io/quarkiverse/openapi/generator/it/creds/CustomCredentialsProviderTest.java Co-authored-by: Gonzalo Muñoz <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]> * Fix IT parent version Signed-off-by: Ricardo Zanini <[email protected]> --------- Signed-off-by: Ricardo Zanini <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]> Co-authored-by: Gonzalo Muñoz <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
Fix #1156.
Additionally, now OAuth2 provider also has an injected CredentialsProvider.
Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.